Defaulting USER to postgres does not make sense as odoo prevents
creating a database with the user `postgres` (however, there's a bug
that allows it when set by environment variable, but still it does not
work later because Odoo does not use the environment variable to find
the databases in the `list_dbs` method).
Defaulting PASSWORD to odoo makes sense because it's what we set in
the documentationm and is even mandatory since we chose to pass the pg
connections parameters[1] and we did not set a default value for it.
[1] a3d207f2d4
Do not assume that Odoo will handle correctly the PG* environment
variables, because it won't.
We also rename the PG* variables in order to avoid confusion since we do
not export them anymore.
The entry points of the Odoo docker images require the presence of the
following environment variables:
- DB_PORT_5432_TCP_ADDR
- DB_PORT_5432_TCP_PORT
- DB_ENV_POSTGRES_USER
- DB_ENV_POSTGRES_PASSWORD
We use them to set the PGHOST, PGPORT, PGUSER and PGPASSWORD environment
variable that will then be read by Odoo in order to connect to the
database server.
As the first ones are automatically created by Docker when we use the linking
system, it's not possible to run Odoo without the linking system and,
for example, with Docker compose.
In order to make it work with Docker compose and keep the backward
compatibility with the linking system, we have to provide sane
fallbacks to the assignation of the PGHOST, PGPORT, PGUSER and
PGPASSWORD environment variable.
We do that in this commit by defaulting the assignation of the postgres
host to "db" and the port to "5432" because, if you follow our image
documentation, that's what you get. We also introduce the handling of
two others environment variable in the Odoo entry point: POSTGRES_USER
and POSTGRES_PASSWORD. They will be used as fallbacks for
DB_ENV_POSTGRES_USER and DB_ENV_POSTGRES_PASSWORD.
